From 0fea99f850dbb680735ba2fef4517f45c0ac98dc Mon Sep 17 00:00:00 2001 From: Roman Reiss Date: Fri, 4 Sep 2015 12:48:20 +0200 Subject: [PATCH 1/4] node: add NODE_REPL_HISTORY to --help, fix case Added NODE_REPL_HISTORY to the environment variables in the --help print and made all descriptions start with lower case for consistency. --- src/node.cc | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/node.cc b/src/node.cc index 46ce047f673d92..7b8448cf4c335f 100644 --- a/src/node.cc +++ b/src/node.cc @@ -3064,7 +3064,7 @@ static void PrintHelp() { " --icu-data-dir=dir set ICU data load path to dir\n" " (overrides NODE_ICU_DATA)\n" #if !defined(NODE_HAVE_SMALL_ICU) - " Note: linked-in ICU data is\n" + " note: linked-in ICU data is\n" " present.\n" #endif #endif @@ -3076,13 +3076,14 @@ static void PrintHelp() { "NODE_PATH ':'-separated list of directories\n" #endif " prefixed to the module search path.\n" - "NODE_DISABLE_COLORS Set to 1 to disable colors in the REPL\n" + "NODE_DISABLE_COLORS set to 1 to disable colors in the REPL\n" #if defined(NODE_HAVE_I18N_SUPPORT) - "NODE_ICU_DATA Data path for ICU (Intl object) data\n" + "NODE_ICU_DATA data path for ICU (Intl object) data\n" #if !defined(NODE_HAVE_SMALL_ICU) " (will extend linked-in data)\n" #endif #endif + "NODE_REPL_HISTORY persistent history file location\n" "\n" "Documentation can be found at https://nodejs.org/\n"); } From 410559ee702cace6f351b9feb7e04da9c1ca39d6 Mon Sep 17 00:00:00 2001 From: Roman Reiss Date: Fri, 4 Sep 2015 15:26:25 +0200 Subject: [PATCH 2/4] add vars to node.1 and reword help description --- doc/node.1 | 8 +++++++- src/node.cc | 2 +- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/doc/node.1 b/doc/node.1 index f135a83dfa789d..fd5325b6af5aaa 100644 --- a/doc/node.1 +++ b/doc/node.1 @@ -72,9 +72,15 @@ and servers. .IP NODE_PATH \':\'\-separated list of directories prefixed to the module search path. - .IP NODE_DISABLE_COLORS If set to 1 then colors will not be used in the REPL. +.IP NODE_ICU_DATA +Data path for ICU (Intl object) data. Will extend linked-in data when compiled +with small-icu support. +.IP NODE_REPL_HISTORY +Path to the file used to store the persistent REPL history. The default path +is ~/.node_repl_history, which can be overriden with this variable. Setting the +value to an empty string "" disables persistent REPL history. .SH V8 OPTIONS diff --git a/src/node.cc b/src/node.cc index 7b8448cf4c335f..7fb791834e8990 100644 --- a/src/node.cc +++ b/src/node.cc @@ -3083,7 +3083,7 @@ static void PrintHelp() { " (will extend linked-in data)\n" #endif #endif - "NODE_REPL_HISTORY persistent history file location\n" + "NODE_REPL_HISTORY path to the persistent REPL history file\n" "\n" "Documentation can be found at https://nodejs.org/\n"); } From 9947aa09bfdd160b91b925f0d99726db1f5b410a Mon Sep 17 00:00:00 2001 From: Roman Reiss Date: Fri, 4 Sep 2015 15:28:26 +0200 Subject: [PATCH 3/4] fix typo, small rewording --- doc/node.1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/node.1 b/doc/node.1 index fd5325b6af5aaa..a00dc6c421827b 100644 --- a/doc/node.1 +++ b/doc/node.1 @@ -79,7 +79,7 @@ Data path for ICU (Intl object) data. Will extend linked-in data when compiled with small-icu support. .IP NODE_REPL_HISTORY Path to the file used to store the persistent REPL history. The default path -is ~/.node_repl_history, which can be overriden with this variable. Setting the +is ~/.node_repl_history, which is overridden by this variable. Setting the value to an empty string "" disables persistent REPL history. .SH V8 OPTIONS From 5d0956054e3b733c1d46746a035ada70629675e1 Mon Sep 17 00:00:00 2001 From: Roman Reiss Date: Fri, 4 Sep 2015 16:34:36 +0200 Subject: [PATCH 4/4] parens --- doc/node.1 | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/node.1 b/doc/node.1 index a00dc6c421827b..af494dade98b22 100644 --- a/doc/node.1 +++ b/doc/node.1 @@ -80,7 +80,7 @@ with small-icu support. .IP NODE_REPL_HISTORY Path to the file used to store the persistent REPL history. The default path is ~/.node_repl_history, which is overridden by this variable. Setting the -value to an empty string "" disables persistent REPL history. +value to an empty string ("") disables persistent REPL history. .SH V8 OPTIONS