From 69c1ff9615c4f5f0e638053367311e3d81dba2e4 Mon Sep 17 00:00:00 2001 From: toboid Date: Mon, 6 Feb 2017 21:08:34 +0000 Subject: [PATCH 1/2] test: verify error message from buffer.includes --- test/parallel/test-buffer-includes.js | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js index 9b0aef0ad7652d..17d2626e84cca3 100644 --- a/test/parallel/test-buffer-includes.js +++ b/test/parallel/test-buffer-includes.js @@ -275,15 +275,17 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) { } } +const expectedError = + /^TypeError: "val" argument must be string, number, Buffer or Uint8Array$/; assert.throws(function() { b.includes(function() { }); -}); +}, expectedError); assert.throws(function() { b.includes({}); -}); +}, expectedError); assert.throws(function() { b.includes([]); -}); +}, expectedError); // test truncation of Number arguments to uint8 { From 83c8f293d570a0dbb356ccb8bd2d0de954e6b667 Mon Sep 17 00:00:00 2001 From: toboid Date: Tue, 7 Feb 2017 21:10:51 +0000 Subject: [PATCH 2/2] test: use arrow funcs verifying buffer.includes --- test/parallel/test-buffer-includes.js | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/test/parallel/test-buffer-includes.js b/test/parallel/test-buffer-includes.js index 17d2626e84cca3..ddd7bf36a40597 100644 --- a/test/parallel/test-buffer-includes.js +++ b/test/parallel/test-buffer-includes.js @@ -277,13 +277,13 @@ for (let lengthIndex = 0; lengthIndex < lengths.length; lengthIndex++) { const expectedError = /^TypeError: "val" argument must be string, number, Buffer or Uint8Array$/; -assert.throws(function() { - b.includes(function() { }); +assert.throws(() => { + b.includes(() => {}); }, expectedError); -assert.throws(function() { +assert.throws(() => { b.includes({}); }, expectedError); -assert.throws(function() { +assert.throws(() => { b.includes([]); }, expectedError);