Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sqlite module consitent with other modules like fs #56940

Open
geeksilva97 opened this issue Feb 6, 2025 · 1 comment · May be fixed by #56991
Open

Make sqlite module consitent with other modules like fs #56940

geeksilva97 opened this issue Feb 6, 2025 · 1 comment · May be fixed by #56991
Labels
feature request Issues that request new features to be added to Node.js. sqlite Issues and PRs related to the SQLite subsystem.

Comments

@geeksilva97
Copy link
Contributor

What is the problem this feature will solve?

node:sqlite module deals with paths for the database location. We should support Buffer and URL following up on this comment. Just like fs does.

What is the feature you are proposing to solve the problem?

Support both the three options: String, Buffer and URL

What alternatives have you considered?

No response
@geeksilva97 geeksilva97 added the feature request Issues that request new features to be added to Node.js. label Feb 6, 2025
@github-project-automation github-project-automation bot moved this to Awaiting Triage in Node.js feature requests Feb 6, 2025
@cjihrig cjihrig added the sqlite Issues and PRs related to the SQLite subsystem. label Feb 6, 2025
@geeksilva97
Copy link
Contributor Author

I will work on it before the aggregate function 😃

@geeksilva97 geeksilva97 linked a pull request Feb 10, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request Issues that request new features to be added to Node.js. sqlite Issues and PRs related to the SQLite subsystem.
Projects
Node.js feature requests
Status: Awaiting Triage
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] sqlite,test,doc: accept Buffer and URL as paths geeksilva97/node
2 participants
@cjihrig @geeksilva97