Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support packaging debug binaries in vcbuild.bat #52281

Closed
segevfiner opened this issue Mar 30, 2024 · 1 comment
Closed

Support packaging debug binaries in vcbuild.bat #52281

segevfiner opened this issue Mar 30, 2024 · 1 comment
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.

Comments

@segevfiner
Copy link
Contributor

What is the problem this feature will solve?

When using Node as a shared library (Embedding) in Windows, you will also need a debug build of Node.js for building your application in debug mode as in Windows a debug build uses a debug version of the CRT which cannot be mixed with the release CRT (Has its own separate heap for example, even with CRT versions that are based on the universal CRT which also has separate debug/release builds).

The current vcbuild.bat doesn't support packaging a debug build though, which is useful to have a clean tree with the Node.js headers, shared library, node.def, and so on. So you don't have to write definitions to link against the Node.js source tree, which requires adding all the necessary include paths under deps for the dependencies.

What is the feature you are proposing to solve the problem?

Support building a package from vcbuild.bat for a debug build. Alternatively, we can also just include a Debug directory under the normal release package with the node shared library, import library and def file for debug if debug is built in that tree to produce one package that includes both release and debug builds for the shared node case.

What alternatives have you considered?

Wrangle the files by myself, which is annoying, and can introduce confusion over the directory layout of them as whatever way I choose is not a standard.

@segevfiner segevfiner added the feature request Issues that request new features to be added to Node.js. label Mar 30, 2024
@VoltrexKeyva VoltrexKeyva added the build Issues and PRs related to build files or the CI. label Mar 30, 2024
@segevfiner
Copy link
Contributor Author

segevfiner commented Mar 31, 2024

BTW I'm willing to contribute a pull request for this, but I want to know which approach is preferred by the Node devs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. feature request Issues that request new features to be added to Node.js.
Projects
None yet
Development

No branches or pull requests

2 participants