Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAP parser fails with zero width joiner #48397

Closed
TheChilliPL opened this issue Jun 8, 2023 · 1 comment
Closed

TAP parser fails with zero width joiner #48397

TheChilliPL opened this issue Jun 8, 2023 · 1 comment

Comments

@TheChilliPL
Copy link

Version

v18.12.0

Platform

Microsoft Windows NT 10.0.25375.0 x64

Subsystem

No response

What steps will reproduce the bug?

All you need is to run

assert.deepEqual("πŸ‘¨β€πŸ‘©β€πŸ‘§β€πŸ‘¦", "");

inside a test case.

How often does it reproduce? Is there a required condition?

Seems to happen every time there's a ZWJ in the test.

What is the expected behavior? Why is that the expected behavior?

It should not crash the parser, because it doesn't make sense for it to crash the parser. ZWJ should log correctly.

What do you see instead?

Well, it crashes the parser:

  Error [ERR_TAP_LEXER_ERROR]: Unexpected character: ‍ at line 1, column 0
      at Socket.emit (node:events:511:28) {
    code: 'ERR_TAP_LEXER_ERROR'
  }

Additional information

No response

@cjihrig
Copy link
Contributor

cjihrig commented Jun 8, 2023

The TAP parser was removed in #47867. I think that has only made its way to v20.2.0 and newer so far, but it should be backported eventually.

@cjihrig cjihrig closed this as completed Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants