Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS binaries: UV_FS_COPYFILE_FICLONE not supported 18.9.0 #44747

Closed
kwasimensah opened this issue Sep 22, 2022 · 1 comment
Closed

macOS binaries: UV_FS_COPYFILE_FICLONE not supported 18.9.0 #44747

kwasimensah opened this issue Sep 22, 2022 · 1 comment
Labels
fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX.

Comments

@kwasimensah
Copy link

kwasimensah commented Sep 22, 2022

Version

v18.9.0

Platform

Darwin.local 21.6.0 Darwin Kernel Version 21.6.0: Mon Aug 22 20:17:10 PDT 2022; root:xnu-8020.140.49~2/RELEASE_X86_64 x86_64

Subsystem

fs

What steps will reproduce the bug?

run node index.js in https://github.com/kwasimensah/fi-clone-mac-repro

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

The copy succeeds on mac

What do you see instead?

[Error: ENOSYS: function not implemented, copyfile 'origfile.txt' -> 'newfile.txt'] {
  errno: -78,
  code: 'ENOSYS',
  syscall: 'copyfile',
  path: 'origfile.txt',
  dest: 'newfile.txt'
}

Additional information

Seems like a repeat of #24521 . Does it make sense to add a test to catch this?

@kwasimensah kwasimensah changed the title macOS binaries: UV_FS_COPYFILE_FICLONE not supported 18.3.0 macOS binaries: UV_FS_COPYFILE_FICLONE not supported 18.9.0 Sep 22, 2022
@VoltrexKeyva VoltrexKeyva added fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX. labels Sep 23, 2022
@bnoordhuis
Copy link
Member

Your test uses UV_FS_COPYFILE_FICLONE_FORCE but that flag is not supported on macos (because it's rife with bugs), only linux. See libuv/libuv#2578 and libuv/libuv#3654 for more info.

I'm going to close this as it's a known issue. There isn't much that node can do and it's unclear if libuv can work around apple's bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fs Issues and PRs related to the fs subsystem / file system. macos Issues and PRs related to the macOS platform / OSX.
Projects
None yet
Development

No branches or pull requests

3 participants