Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong variable used in documentation #23899

Closed
amitguptagwl opened this issue Oct 26, 2018 · 5 comments
Closed

Wrong variable used in documentation #23899

amitguptagwl opened this issue Oct 26, 2018 · 5 comments
Labels
doc Issues and PRs related to the documentations.

Comments

@amitguptagwl
Copy link

Sorry if I'm raising this issue on the wrong place.

In the documentation, https://nodejs.org/en/docs/guides/dont-block-the-event-loop/ took = process.hrtime(n); should be replaced by took = process.hrtime(before);

@cjihrig
Copy link
Contributor

cjihrig commented Oct 26, 2018

I think you're right. Would you care to open a PR?

@ChALkeR ChALkeR added the doc Issues and PRs related to the documentations. label Oct 26, 2018
@amitguptagwl
Copy link
Author

Sure, if you can guide me to the correct file. I couldn't find the doc in https://github.com/nodejs/node/tree/master/doc/guides folder

@richardlau
Copy link
Member

It's not in this repository, it's in the website's repository: https://github.com/nodejs/nodejs.org/blob/master/locale/en/docs/guides/dont-block-the-event-loop.md.

@ghost
Copy link

ghost commented Oct 26, 2018

I saw this was unassigned and went ahead and made a PR. I hope you don't mind (^_^)

@amitguptagwl
Copy link
Author

amitguptagwl commented Oct 26, 2018

@Flowkrad Though I don't mind and thanks to keeping me free, I prefer not to do like this. It wastes others time otherwise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

No branches or pull requests

4 participants