Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

building against latest version of v8 requires C++14 #17065

Closed
bcoe opened this issue Nov 16, 2017 · 2 comments
Closed

building against latest version of v8 requires C++14 #17065

bcoe opened this issue Nov 16, 2017 · 2 comments
Labels
build Issues and PRs related to build files or the CI.

Comments

@bcoe
Copy link
Contributor

bcoe commented Nov 16, 2017

  • Version: N/A
  • Platform: OSX
  • Subsystem: N/A

I gather that, due to this change:

https://chromium-review.googlesource.com/c/v8/v8/+/728026/10/src/x64/assembler-x64.h

Building Node.js against newer versions of V8 now requires C++14. Took me a little while to figure out that on OSX I need to set CXXFLAGS="-std=c++1y".

tldr; I think the build configuration might need to be updated a bit, and I thought it would be worth tracking in an issue.
@bcoe bcoe changed the title building against latest version of v8 requires building against latest version of v8 requires C++14 Nov 16, 2017
@targos
Copy link
Member

targos commented Nov 16, 2017

Related:

#16501
nodejs/build#945

@mscdex mscdex added the build Issues and PRs related to build files or the CI. label Nov 16, 2017
@targos
Copy link
Member

targos commented Jan 15, 2018

I'm closing this issue because the master branch is not affected and #17489 updates the build configuration to support the changes in V8.

@targos targos closed this as completed Jan 15, 2018
This was referenced Dec 2, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mscdex @bcoe @targos