querystring.parse() not handling trailing spaces (+) in parameters correctly

[jaysylvester]

• Version: v8.1.4
• Platform: Linux 3.16.0-4-amd64 deps: update openssl to 1.0.1j #1 SMP Debian 3.16.43-2 (2017-04-30) x86_64 GNU/Linux
• Subsystem: querystring

I'm seeing an issue with querystring.parse() in v8.4.1 that I don't have with v6.11.1. When I parse application/x-www-form-urlencoded form data, inputs containing returns and line feeds with a trailing space on the last line aren't parsing correctly.

Let's say I have <textarea name="content"> that contains the following on submit:

foo
bar

I get the expected result after parsing the form body:

foo\r\nbar

However, if I add a trailing space after "bar", I get the following form body:

content=foo%0D%0Abar+

And the following from querystring.parse():

{
  content: 'foo%0D%0Abar '
}

I'm using formidable and thought it might be a bug in that, so I wrote a simple parser myself and still have the same issue.

var body = '',
    form = {};

request.on('data', function (chunk) {
  body += chunk.toString();
});

request.on('end', function () {
  form = querystring.parse(body);
});

As mentioned previously, everything works as expected using v6.11.1. Not sure if this is an intentional change that I missed or a bug.

[TimothyGu]

Duplicate of #13773. The bug has already been fixed in master, and the next v8.x release will have it fixed also.

[jaysylvester]

Sorry, searched but didn't find that issue. Thanks for the update.