Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zlib fails on Uint8Array #12072

Closed
nyurik opened this issue Mar 27, 2017 · 2 comments
Closed

zlib fails on Uint8Array #12072

nyurik opened this issue Mar 27, 2017 · 2 comments
Labels
zlib Issues and PRs related to the zlib subsystem.

Comments

@nyurik
Copy link

nyurik commented Mar 27, 2017

Large buffers (300k+) stored as Uint8Array throw an exception when passed to zlib.gzipSync(data), even though zlibBufferSync() seems to work just fine after modifying the parameter type validation at

node/lib/zlib.js

Line 124 in 98e54b0

if (!(buffer instanceof Buffer))

@targos
Copy link
Member

targos commented Mar 27, 2017

This is being fixed in #12001.

@mscdex mscdex added the zlib Issues and PRs related to the zlib subsystem. label Mar 27, 2017
@addaleax
Copy link
Member

addaleax commented Apr 3, 2017

Fixed by 91383e4, thanks for the report! The commit will most likely be included in the 8.0.0 release later in April.

@addaleax addaleax closed this as completed Apr 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mscdex @addaleax @nyurik @targos