From d89cce5192fee95f8c89fddc33ff799513c270cf Mon Sep 17 00:00:00 2001 From: Salame William Date: Thu, 28 Dec 2017 17:31:53 +0100 Subject: [PATCH] doc: add references to PR communication articles Added some references to PR communication articles in Helpful Ressources inside COLLABORATOR_GUIDE.md PR-URL: https://github.com/nodejs/node/pull/17902 Fixes: https://github.com/nodejs/node/issues/16359 Reviewed-By: Vse Mozhet Byt Reviewed-By: James M Snell Reviewed-By: Gibson Fahnestock Reviewed-By: Luigi Pinca Reviewed-By: Weijia Wang --- COLLABORATOR_GUIDE.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/COLLABORATOR_GUIDE.md b/COLLABORATOR_GUIDE.md index baaf270247d32c..21eb9a872e409e 100644 --- a/COLLABORATOR_GUIDE.md +++ b/COLLABORATOR_GUIDE.md @@ -116,6 +116,11 @@ oppose the PR, it can be landed. Where there is disagreement among TSC members or objections from one or more Collaborators, `semver-major` pull requests should be put on the TSC meeting agenda. +#### Helpful resources + +* How to respectfully and usefully review code, part [one](https://mtlynch.io/human-code-reviews-1/) and [two](https://mtlynch.io/human-code-reviews-2/) +* [How to write a positive code review](https://css-tricks.com/code-review-etiquette/) + ### Waiting for Approvals Before landing pull requests, sufficient time should be left for input