Skip to content

Commit d6fc7e3

Browse files
committed
doc: enable eslint prefer-template rule
PR-URL: #18831 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Matheus Marchini <[email protected]> Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Anatoli Papirovski <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
1 parent 3a2e912 commit d6fc7e3

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

doc/.eslintrc.yaml

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ rules:
1212
no-var: error
1313
prefer-const: error
1414
prefer-rest-params: error
15+
prefer-template: error
1516

1617
# Stylistic Issues
1718
no-multiple-empty-lines: [error, {max: 1, maxEOF: 0, maxBOF: 0}]

doc/api/esm.md

+2-2
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ given module specifier and parent file URL:
118118

119119
```js
120120
const baseURL = new URL('file://');
121-
baseURL.pathname = process.cwd() + '/';
121+
baseURL.pathname = `${process.cwd()}/`;
122122

123123
export async function resolve(specifier,
124124
parentModuleURL = baseURL,
@@ -161,7 +161,7 @@ const builtins = Module.builtinModules;
161161
const JS_EXTENSIONS = new Set(['.js', '.mjs']);
162162

163163
const baseURL = new URL('file://');
164-
baseURL.pathname = process.cwd() + '/';
164+
baseURL.pathname = `${process.cwd()}/`;
165165

166166
export function resolve(specifier, parentModuleURL = baseURL, defaultResolve) {
167167
if (builtins.includes(specifier)) {

doc/api/http.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -422,7 +422,7 @@ const req = http.request(options);
422422
req.end();
423423

424424
req.on('information', (res) => {
425-
console.log('got information prior to main response: ' + res.statusCode);
425+
console.log(`Got information prior to main response: ${res.statusCode}`);
426426
});
427427
```
428428

doc/api/stream.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -1852,7 +1852,7 @@ class Counter extends Readable {
18521852
if (i > this._max)
18531853
this.push(null);
18541854
else {
1855-
const str = '' + i;
1855+
const str = String(i);
18561856
const buf = Buffer.from(str, 'ascii');
18571857
this.push(buf);
18581858
}

0 commit comments

Comments
 (0)