From add1c02bda14be1e00f92ef1e7b2c155abaeeeae Mon Sep 17 00:00:00 2001 From: davidmarkclements Date: Wed, 4 Apr 2018 20:29:52 +0200 Subject: [PATCH] errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER from Error to TypeError as a more accurate representation of the error. PR-URL: https://github.com/nodejs/node/pull/19808 Reviewed-By: James M Snell Reviewed-By: Ruben Bridgewater Reviewed-By: Trivikram Kamat Reviewed-By: Matteo Collina --- lib/internal/errors.js | 4 +--- test/parallel/test-http2-info-headers.js | 2 +- test/parallel/test-http2-util-assert-valid-pseudoheader.js | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/lib/internal/errors.js b/lib/internal/errors.js index 570e8d811e4472..f7c444afb23caf 100644 --- a/lib/internal/errors.js +++ b/lib/internal/errors.js @@ -733,10 +733,8 @@ E('ERR_HTTP2_INVALID_INFO_STATUS', 'Invalid informational status code: %s', RangeError); E('ERR_HTTP2_INVALID_PACKED_SETTINGS_LENGTH', 'Packed settings length must be a multiple of six', RangeError); - -// This should probably be a `TypeError`. E('ERR_HTTP2_INVALID_PSEUDOHEADER', - '"%s" is an invalid pseudoheader or is used incorrectly', Error); + '"%s" is an invalid pseudoheader or is used incorrectly', TypeError); E('ERR_HTTP2_INVALID_SESSION', 'The session has been destroyed', Error); E('ERR_HTTP2_INVALID_SETTING_VALUE', 'Invalid value for setting "%s": %s', TypeError, RangeError); diff --git a/test/parallel/test-http2-info-headers.js b/test/parallel/test-http2-info-headers.js index 2313040de12a97..132818c4090037 100644 --- a/test/parallel/test-http2-info-headers.js +++ b/test/parallel/test-http2-info-headers.js @@ -36,7 +36,7 @@ function onStream(stream, headers, flags) { () => stream.additionalHeaders({ ':method': 'POST' }), { code: 'ERR_HTTP2_INVALID_PSEUDOHEADER', - type: Error, + type: TypeError, message: '":method" is an invalid pseudoheader or is used incorrectly' } ); diff --git a/test/parallel/test-http2-util-assert-valid-pseudoheader.js b/test/parallel/test-http2-util-assert-valid-pseudoheader.js index 27050fedd6c579..badd7442ada5b7 100644 --- a/test/parallel/test-http2-util-assert-valid-pseudoheader.js +++ b/test/parallel/test-http2-util-assert-valid-pseudoheader.js @@ -17,7 +17,7 @@ function isNotError(val) { function isError(val) { common.expectsError({ code: 'ERR_HTTP2_INVALID_PSEUDOHEADER', - type: Error, + type: TypeError, message: '":foo" is an invalid pseudoheader or is used incorrectly' })(val); }