From 9bf887475ea878f0f4ac297781e18129432683c4 Mon Sep 17 00:00:00 2001
From: Rich Trott <rtrott@gmail.com>
Date: Tue, 17 Oct 2017 16:15:23 -0700
Subject: [PATCH] test: make test-os-eol engine agnostic
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Do not check the error message if it is generated by the JavaScript
engine (V8, ChakraCore, etc.). Do confirm that it is a `TypeError`.

PR-URL: https://github.com/nodejs/node/pull/16272
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
---
 test/parallel/test-os-eol.js | 9 +++------
 1 file changed, 3 insertions(+), 6 deletions(-)

diff --git a/test/parallel/test-os-eol.js b/test/parallel/test-os-eol.js
index 7a7a300717cfe8..412751a151b9a2 100644
--- a/test/parallel/test-os-eol.js
+++ b/test/parallel/test-os-eol.js
@@ -8,12 +8,9 @@ const eol = common.isWindows ? '\r\n' : '\n';
 
 assert.strictEqual(os.EOL, eol);
 
-common.expectsError(function() {
-  os.EOL = 123;
-}, {
-  type: TypeError,
-  message: /^Cannot assign to read only property 'EOL' of object '#<Object>'$/
-});
+// Test that the `Error` is a `TypeError` but do not check the message as it
+// varies between different JavaScript engines.
+assert.throws(function() { os.EOL = 123; }, TypeError);
 
 const foo = 'foo';
 Object.defineProperties(os, {