From 86a647899fa50ed7ad93f2a309b176d3e0321c08 Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Sat, 11 Feb 2017 14:36:30 +0100 Subject: [PATCH] build: don't rebuild test/gc add-on unnecessarily Remove the explicit dependency on $(NODE_EXE), it always triggers a rebuild due to it being a .PHONY rule. Add-ons in test/addons/ have the same implicit dependency so it isn't completely without precedent. PR-URL: https://github.com/nodejs/node/pull/11311 Reviewed-By: James M Snell Reviewed-By: Sakthipriyan Vairamani --- Makefile | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 2aac5c2f6a26e0..4aaef26da24d23 100644 --- a/Makefile +++ b/Makefile @@ -133,8 +133,10 @@ test-parallel: all test-valgrind: all $(PYTHON) tools/test.py --mode=release --valgrind sequential parallel message -test/gc/build/Release/binding.node: \ - $(NODE_EXE) test/gc/binding.cc test/gc/binding.gyp +# Implicitly depends on $(NODE_EXE). We don't depend on it explicitly because +# it always triggers a rebuild due to it being a .PHONY rule. See the comment +# near the build-addons rule for more background. +test/gc/build/Release/binding.node: test/gc/binding.cc test/gc/binding.gyp $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp rebuild \ --python="$(PYTHON)" \ --directory="$(shell pwd)/test/gc" \