From 837c0fafb0ceb94f90b762e3ba87f96e020316aa Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 27 May 2016 11:38:12 -0700 Subject: [PATCH] test: fix spurious EADDRINUSE in test-https-strict test-https-strict sometimes fails with EADDRINUSE in CI. Remove use of common.PORT to make the test resistant from side effects from other tests that may have not freed up the port. PR-URL: https://github.com/nodejs/node/pull/7024 Reviewed-By: Brian White Reviewed-By: Anna Henningsen Reviewed-By: Colin Ihrig --- test/parallel/test-https-strict.js | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/test/parallel/test-https-strict.js b/test/parallel/test-https-strict.js index 9f845470b0f2e9..6744faacbc615a 100644 --- a/test/parallel/test-https-strict.js +++ b/test/parallel/test-https-strict.js @@ -65,13 +65,9 @@ var server3 = server(options3); var listenWait = 0; -var port = common.PORT; -var port1 = port++; -var port2 = port++; -var port3 = port++; -server1.listen(port1, listening()); -server2.listen(port2, listening()); -server3.listen(port3, listening()); +server1.listen(0, listening()); +server2.listen(0, listening()); +server3.listen(0, listening()); var responseErrors = {}; var expectResponseCount = 0; @@ -131,9 +127,9 @@ function makeReq(path, port, error, host, ca) { } var req = https.get(options); expectResponseCount++; - var server = port === port1 ? server1 - : port === port2 ? server2 - : port === port3 ? server3 + var server = port === server1.address().port ? server1 + : port === server2.address().port ? server2 + : port === server3.address().port ? server3 : null; if (!server) throw new Error('invalid port: ' + port); @@ -156,6 +152,10 @@ function makeReq(path, port, error, host, ca) { function allListening() { // ok, ready to start the tests! + const port1 = server1.address().port; + const port2 = server2.address().port; + const port3 = server3.address().port; + // server1: host 'agent1', signed by ca1 makeReq('/inv1', port1, 'UNABLE_TO_VERIFY_LEAF_SIGNATURE'); makeReq('/inv1-ca1', port1,