From 6269ba334d4c1848efcf7fa436d6d3951838e87e Mon Sep 17 00:00:00 2001
From: Daniel Bevenius <daniel.bevenius@gmail.com>
Date: Tue, 17 Oct 2017 07:27:07 +0200
Subject: [PATCH] test: allow tests to pass without internet

Currently when running the test without an internet connection there are
two JavaScript test failures

This commit moves the two JavaScript tests to test/internet.

Backport-PR-URL: https://github.com/nodejs/node/pull/17171
PR-URL: https://github.com/nodejs/node/pull/16255
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
---
 test/internet/test-dgram-membership.js | 37 ++++++++++++++++++++++++++
 test/parallel/test-dgram-membership.js | 29 --------------------
 2 files changed, 37 insertions(+), 29 deletions(-)
 create mode 100644 test/internet/test-dgram-membership.js

diff --git a/test/internet/test-dgram-membership.js b/test/internet/test-dgram-membership.js
new file mode 100644
index 00000000000000..97bc1e648ad79e
--- /dev/null
+++ b/test/internet/test-dgram-membership.js
@@ -0,0 +1,37 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+const dgram = require('dgram');
+const multicastAddress = '224.0.0.114';
+
+const setup = dgram.createSocket.bind(dgram, { type: 'udp4', reuseAddr: true });
+
+// addMembership() with valid socket and multicast address should not throw
+{
+  const socket = setup();
+  assert.doesNotThrow(() => { socket.addMembership(multicastAddress); });
+  socket.close();
+}
+
+// dropMembership() without previous addMembership should throw
+{
+  const socket = setup();
+  assert.throws(
+    () => { socket.dropMembership(multicastAddress); },
+    /^Error: dropMembership EADDRNOTAVAIL$/
+  );
+  socket.close();
+}
+
+// dropMembership() after addMembership() should not throw
+{
+  const socket = setup();
+  assert.doesNotThrow(
+    () => {
+      socket.addMembership(multicastAddress);
+      socket.dropMembership(multicastAddress);
+    }
+  );
+  socket.close();
+}
diff --git a/test/parallel/test-dgram-membership.js b/test/parallel/test-dgram-membership.js
index 1543b9043f7738..0ecc3d59b5e92a 100644
--- a/test/parallel/test-dgram-membership.js
+++ b/test/parallel/test-dgram-membership.js
@@ -56,32 +56,3 @@ const setup = dgram.createSocket.bind(dgram, {type: 'udp4', reuseAddr: true});
                 /^Error: dropMembership EINVAL$/);
   socket.close();
 }
-
-// addMembership() with valid socket and multicast address should not throw
-{
-  const socket = setup();
-  assert.doesNotThrow(() => { socket.addMembership(multicastAddress); });
-  socket.close();
-}
-
-// dropMembership() without previous addMembership should throw
-{
-  const socket = setup();
-  assert.throws(
-    () => { socket.dropMembership(multicastAddress); },
-    /^Error: dropMembership EADDRNOTAVAIL$/
-  );
-  socket.close();
-}
-
-// dropMembership() after addMembership() should not throw
-{
-  const socket = setup();
-  assert.doesNotThrow(
-    () => {
-      socket.addMembership(multicastAddress);
-      socket.dropMembership(multicastAddress);
-    }
-  );
-  socket.close();
-}