test: remove unnecessary use of common.PORT in addons test

Using port 0 to request an open port from the operating system is sufficient in openssl-client-cert-engine/test.js. PR-URL: #17563 Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Richard Lau <[email protected]> Reviewed-By: Jon Moss <[email protected]> Reviewed-By: Colin Ihrig <[email protected]>
nodejs · Dec 12, 2017 · 5a9172f · 5a9172f
1 parent 03d2514
commit 5a9172f
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/test/addons/openssl-client-cert-engine/test.js b/test/addons/openssl-client-cert-engine/test.js
@@ -21,8 +21,6 @@ const agentKey = fs.readFileSync(fixture.path('/keys/agent1-key.pem'));
 const agentCert = fs.readFileSync(fixture.path('/keys/agent1-cert.pem'));
 const agentCa = fs.readFileSync(fixture.path('/keys/ca1-cert.pem'));
 
-const port = common.PORT;
-
 const serverOptions = {
   key: agentKey,
   cert: agentCert,
@@ -34,11 +32,11 @@ const serverOptions = {
 const server = https.createServer(serverOptions, (req, res) => {
   res.writeHead(200);
   res.end('hello world');
-}).listen(port, common.localhostIPv4, () => {
+}).listen(0, common.localhostIPv4, () => {
   const clientOptions = {
     method: 'GET',
     host: common.localhostIPv4,
-    port: port,
+    port: server.address().port,
     path: '/test',
     clientCertEngine: engine,  // engine will provide key+cert
     rejectUnauthorized: false, // prevent failing on self-signed certificates