Skip to content

Commit

Permalink
deps: V8: cherry-pick 700b1b97e9ab
Browse files Browse the repository at this point in the history
Original commit message:

    [api] Remove deprecated wasm module type check

    The method was deprecated in favor of {IsWasmModuleObject}.

    [email protected]

    Bug: v8:10155
    Change-Id: Id21a1b74dde5576c2c82cc209555c22209a9e5d4
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/2033170
    Reviewed-by: Adam Klein <[email protected]>
    Commit-Queue: Clemens Backes <[email protected]>
    Cr-Commit-Position: refs/heads/master@{#66469}

Refs: v8/v8@700b1b9

PR-URL: #32885
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Ujjwal Sharma <[email protected]>
Reviewed-By: Gerhard Stöbich <[email protected]>
Reviewed-By: Beth Griggs <[email protected]>
  • Loading branch information
addaleax authored and BethGriggs committed Apr 20, 2020
1 parent 9b7a1b0 commit 552cee0
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.23',
'v8_embedder_string': '-node.24',

##### V8 defaults for Node.js #####

Expand Down
3 changes: 0 additions & 3 deletions deps/v8/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -2786,9 +2786,6 @@ class V8_EXPORT Value : public Data {
*/
bool IsWasmModuleObject() const;

V8_DEPRECATED("Use IsWasmModuleObject")
bool IsWebAssemblyCompiledModule() const;

/**
* Returns true if the value is a Module Namespace Object.
*/
Expand Down
1 change: 0 additions & 1 deletion deps/v8/src/api/api.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3438,7 +3438,6 @@ VALUE_IS_SPECIFIC_TYPE(Set, JSSet)
VALUE_IS_SPECIFIC_TYPE(WasmModuleObject, WasmModuleObject)
VALUE_IS_SPECIFIC_TYPE(WeakMap, JSWeakMap)
VALUE_IS_SPECIFIC_TYPE(WeakSet, JSWeakSet)
VALUE_IS_SPECIFIC_TYPE(WebAssemblyCompiledModule, WasmModuleObject)

#undef VALUE_IS_SPECIFIC_TYPE

Expand Down

0 comments on commit 552cee0

Please sign in to comment.