Skip to content

Commit

Permalink
test: fix test-without-async-context-frame.mjs in debug mode
Browse files Browse the repository at this point in the history
The test is spawning the python test runner directly without
considering whether the current build is a debug build or not
i.e. does not propage the mode parameter when the test is
run with --mode=debug, so it always ends up using the release
build to run the test even if the test is being run for debug
builds. This patch fixes that.

PR-URL: #57034
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
  • Loading branch information
joyeecheung authored and targos committed Feb 25, 2025
1 parent 7c7e9f4 commit 51dff8b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions test/parallel/test-async-context-frame.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ describe('AsyncContextFrame', {
it(test, async () => {
const proc = spawn(python, [
testRunner,
`--mode=${process.features.debug ? 'debug' : 'release'}`,
'--node-args=--experimental-async-context-frame',
test,
], {
Expand Down

0 comments on commit 51dff8b

Please sign in to comment.