From 477e674a2a80a311965a87dd1e68705bdb6e0c2f Mon Sep 17 00:00:00 2001 From: Antoine du Hamel Date: Sat, 11 Jan 2025 23:55:07 +0100 Subject: [PATCH] tools: edit `create-release-proposal` workflow MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Small cleanup edits. PR-URL: https://github.com/nodejs/node/pull/56540 Reviewed-By: Richard Lau Reviewed-By: Marco Ippolito Reviewed-By: Rafael Gonzaga Reviewed-By: Luigi Pinca Reviewed-By: Juan José Arboleda Reviewed-By: James M Snell --- .github/workflows/create-release-proposal.yml | 8 ++++---- .../{create-release.sh => create-release-proposal.sh} | 0 2 files changed, 4 insertions(+), 4 deletions(-) rename tools/actions/{create-release.sh => create-release-proposal.sh} (100%) diff --git a/.github/workflows/create-release-proposal.yml b/.github/workflows/create-release-proposal.yml index f3add22090cbc0..55bc892eb909a4 100644 --- a/.github/workflows/create-release-proposal.yml +++ b/.github/workflows/create-release-proposal.yml @@ -61,7 +61,7 @@ jobs: - name: Set up ghauth config (Ubuntu) run: | mkdir -p "${XDG_CONFIG_HOME:-~/.config}/changelog-maker" - echo '{}' | jq '{user: env.GITHUB_ACTOR, token: env.TOKEN}' > "${XDG_CONFIG_HOME:-~/.config}/changelog-maker/config.json" + jq --null-input '{user: env.GITHUB_ACTOR, token: env.TOKEN}' > "${XDG_CONFIG_HOME:-~/.config}/changelog-maker/config.json" env: TOKEN: ${{ github.token }} @@ -73,9 +73,9 @@ jobs: - name: Start git node release prepare # The curl command is to make sure we run the version of the script corresponding to the current workflow. run: | - git update-index --assume-unchanged tools/actions/create-release.sh - curl -fsSLo tools/actions/create-release.sh https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release.sh - ./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}" + git update-index --assume-unchanged tools/actions/create-release-proposal.sh + curl -fsSLo tools/actions/create-release-proposal.sh https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release-proposal.sh + ./tools/actions/create-release-proposal.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}" env: GH_TOKEN: ${{ github.token }} # We want the bot to push the push the release commit so CI runs on it. diff --git a/tools/actions/create-release.sh b/tools/actions/create-release-proposal.sh similarity index 100% rename from tools/actions/create-release.sh rename to tools/actions/create-release-proposal.sh