From 2f169ad58aefe7c9406fd2062da33172f87e3792 Mon Sep 17 00:00:00 2001 From: Rafael Gonzaga Date: Wed, 13 Jul 2022 14:30:19 -0300 Subject: [PATCH] doc: clarify release process for new releasers MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit PR-URL: https://github.com/nodejs/node/pull/43739 Reviewed-By: Michaël Zasso Reviewed-By: Beth Griggs Reviewed-By: Richard Lau Reviewed-By: Myles Borins --- doc/contributing/releases.md | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/doc/contributing/releases.md b/doc/contributing/releases.md index 4c93944bb69ab3..f9e239a84ea179 100644 --- a/doc/contributing/releases.md +++ b/doc/contributing/releases.md @@ -468,7 +468,20 @@ failed build if you start again! Jenkins collects the artifacts from the builds, allowing you to download and install the new build. Make sure that the build appears correct. Check the version numbers, and perform some basic checks to confirm that all is well with -the build before moving forward. +the build before moving forward. Use the following list as a baseline: + +* `process.version` is as expected +* `process.release` is as expected +* `process.versions` is as expected (for example, `openssl` or `llhttp` version + must be in the expected updated version) +* npm version (check it matches what we expect) +* Run the test suite against the built binaries (optional) + +```console +./tools/test.py --shell ~/Downloads/node-v18.5.0-linux-x64/bin/node +``` + +There may be test issues if the branch used to test does not match the Node.js binary. ### 11. Tag and sign the release commit @@ -510,6 +523,8 @@ include the release code name. The tag **must** be signed using the GPG key that's listed for you on the project README. +**Note**: Don't push the tag to remote at this point. + ### 12. Set up for the next release On release proposal branch, edit `src/node_version.h` again and: