timers: do not expose .unref()._handle._list

The list is defunct at this point. I believe this to be in effect a minor defect from 3eecdf9 PR-URL: #8422 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Julien Gilli <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]> Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: James M Snell <[email protected]>
nodejs · Sep 20, 2017 · 11f7dcf · 11f7dcf
1 parent 87bddda
commit 11f7dcf
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/lib/timers.js b/lib/timers.js
@@ -598,6 +598,9 @@ Timeout.prototype.unref = function() {
     }
 
     var handle = reuse(this);
+    if (handle) {
+      handle._list = undefined;
+    }
 
     this._handle = handle || new TimerWrap();
     this._handle.owner = this;

diff --git a/test/parallel/test-timers-unref-reuse-no-exposed-list.js b/test/parallel/test-timers-unref-reuse-no-exposed-list.js
@@ -0,0 +1,14 @@
+'use strict';
+
+require('../common');
+const assert = require('assert');
+
+const timer1 = setTimeout(() => {}, 1).unref();
+assert.strictEqual(timer1._handle._list, undefined,
+                   'timer1._handle._list should be undefined');
+
+// Check that everything works even if the handle was not re-used.
+setTimeout(() => {}, 1);
+const timer2 = setTimeout(() => {}, 1).unref();
+assert.strictEqual(timer2._handle._list, undefined,
+                   'timer2._handle._list should be undefined');