Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Include full ICU data in binary installers #8995

Closed
misterdjules opened this issue Jan 8, 2015 · 2 comments
Closed

Include full ICU data in binary installers #8995

misterdjules opened this issue Jan 8, 2015 · 2 comments

Comments

@misterdjules
Copy link

If and when #8994 lands, binary installers will ship with small ICU data embedded in the executable file, with data included only for the English language.

Eventually, we want to ship binary installers with full ICU data included as a separate .dat file that is loaded on startup.

This depends on #8983 to be able to load the separate .dat file from a directory relative to the location where node is installed.

Some parts of the implementation of https://github.com/srl295/node/pull/15 could be reused.

cc @srl295 @tjfontaine

@piscisaureus
Copy link

If and when #8994 lands, binary installers will ship with small ICU data embedded in the executable file, with data included only for the English language.
Eventually, we want to ship binary installers with full ICU data included as a separate .dat file that is loaded on startup.

But what's the benefit over just building with icu-full, then?

@srl295
Copy link
Member

srl295 commented Jan 16, 2015

@piscisaureus a couple..

  • mac can have 1 copy of the data instead of 2 (fat binaries would have a 32 and a 64 bit)
  • can easily update the data by replacing the file

downside is the data has to be located relative to the binary.

@misterdjules misterdjules modified the milestones: 0.12.3, 0.12.2 Apr 1, 2015
@misterdjules misterdjules modified the milestones: 0.12.3, 0.12.4 May 14, 2015
@misterdjules misterdjules modified the milestones: 0.12.4, 0.12.5 May 25, 2015
@misterdjules misterdjules modified the milestones: 0.12.5, 0.12.6 Jun 22, 2015
@misterdjules misterdjules modified the milestones: 0.12.6, 0.12.7, 0.12.8 Jul 6, 2015
@Trott Trott closed this as completed Apr 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants