Investigate v0.10 flaky test test-http-pipeline-flood

[orangemocha]

a2f879f marked this test as flaky in v0.10 so that it doesn't block merges with Jenkins and node-accept-pull-request.

As a follow up, we should investigate why this test is failing in v0.10. Some of the tests marked as flaky in a2f879f fail intermittently, while others fail persistently. For the latter, an explicit skip for the specific platform might be more appropriate.

My guess is that a good percentage of these tests fail because of issues with the test itself, not node. It's likely that those issues were fixed in v0.12, so it might be a good idea to look for changes to the same test in git history in v0.12, or even simply trying the v0.12 version of the test with node v0.10.

/cc: @joyent/node-collaborators

[dnakamura]

I've already been looking at this one. I can say that the test is flaky on windows due to the very small tcp buffer sizes. Also the test is not particularly well written. I'm working on a rewrite to better test desired behavior

[dnakamura]

Also, in v0.12 releases the number of requests asserted has been lowered to 250 instead of 500 (e3ec2f7). This seems to fix on platforms other than windows. Ultimately, asserting a specific number of requests does not make much sense, as in my testing when the desired behavior does not exists the test runs indefinitely

[misterdjules]

@orangemocha @dnakamura FYI, marking the test as flaky for Windows in v0.12 with #25707.

[misterdjules]

Created #25732 for Windows and v0.12.