-
Notifications
You must be signed in to change notification settings - Fork 96
compile a proper diff of changes from node not in io.js #1
Comments
hmmm, perhaps there is overlap because we merged in node back when it was |
I did some work towards this here. |
The above was compiled from the commits since 372a2f5, which is the result of |
@chrisdickinson 👍 very nice and quite helpful. |
So, might as well start going through. comments in no particular order yet: (I'll re-arrange the commits by subsystem soon.)
Are those commits from node already on the deps as well? io.js has only accepted floating patches if they already exist upstream.
We removed mdb_v8 entirely, as per nodejs/node#1023 .. what's it even do?
As I think you already know, we removed that entirely as per nodejs/node#315
We should probably still port that over to io.js in some form soon anyways. There is however, a timers re-write in the pipe. |
Although a marginal improvement, there is a much simpler solution to fix the problem this was intended to fix. That's why I didn't port it over from node 0.10 at the time. |
It's what Joyent uses for their dtrace and mdb jsstack integration. They don't bother to keep the V8 bits up to date and it's not relevant for non-SmartOS platforms so it got the ax. |
@Fishrock123 ... do we need to keep this one open? |
Hmmm, don't think so, we can always check back if we think we missed anything. |
Something seems off about nodejs/node-v0.x-archive@3a9754a...master
I think 3a9754a was supposed to be io.js's base, however. cc @chrisdickinson?
But we have some of the changes into december, and I'm pretty sure they weren't ported ones.
The text was updated successfully, but these errors were encountered: