chakrashim: Fix Error.captureStackTrace

Error.captureStackTrace did not convert the type of line and column numbers to numbers while creating the v8 capture objects. This breaks modules which assumes number types. Changed to call parseInt if line and column numbers are defined PR-URL: #483 Reviewed-By: Kyle Farnung <[email protected]> Reviewed-By: Jimmy Thomson <[email protected]>
nodejs · Mar 8, 2018 · cd48200 · cd48200
1 parent 1fc7fe3
commit cd48200
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/deps/chakrashim/lib/chakra_shim.js b/deps/chakrashim/lib/chakra_shim.js
@@ -157,8 +157,8 @@
       const fileDetails = stackDetails[2].split(fileDetailsSplitter);
 
       const fileName = fileDetails[0];
-      const lineNumber = fileDetails[1] ? fileDetails[1] : 0;
-      const columnNumber = fileDetails[3] ? fileDetails[3] : 0;
+      const lineNumber = fileDetails[1] ? parseInt(fileDetails[1]) : 0;
+      const columnNumber = fileDetails[3] ? parseInt(fileDetails[3]) : 0;
 
       errstack.push(new StackFrame(func, funcName, fileName, lineNumber,
                                    columnNumber));