n-api,test: fixing test breaks for chakracore

* n-api: added implementation for new number APIs * test-inspector: added specific message
nodejs · Aug 18, 2017 · bc4b141 · bc4b141
1 parent b060614
commit bc4b141
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 2 deletions.
diff --git a/src/node_api_jsrt.cc b/src/node_api_jsrt.cc
@@ -1122,14 +1122,40 @@ napi_status napi_create_string_utf16(napi_env env,
   return napi_ok;
 }
 
-napi_status napi_create_number(napi_env env,
+napi_status napi_create_double(napi_env env,
                                double value,
                                napi_value* result) {
   CHECK_ARG(result);
   CHECK_JSRT(JsDoubleToNumber(value, reinterpret_cast<JsValueRef*>(result)));
   return napi_ok;
 }
 
+napi_status napi_create_int32(napi_env env,
+                              int32_t value,
+                              napi_value* result) {
+  CHECK_ARG(result);
+  CHECK_JSRT(JsIntToNumber(value, reinterpret_cast<JsValueRef*>(result)));
+  return napi_ok;
+}
+
+napi_status napi_create_uint32(napi_env env,
+                               uint32_t value,
+                               napi_value* result) {
+  CHECK_ARG(result);
+  CHECK_JSRT(JsDoubleToNumber(static_cast<double>(value),
+                              reinterpret_cast<JsValueRef*>(result)));
+  return napi_ok;
+}
+
+napi_status napi_create_int64(napi_env env,
+                              int64_t value,
+                              napi_value* result) {
+  CHECK_ARG(result);
+  CHECK_JSRT(JsDoubleToNumber(static_cast<double>(value),
+                              reinterpret_cast<JsValueRef*>(result)));
+  return napi_ok;
+}
+
 napi_status napi_get_boolean(napi_env env, bool value, napi_value* result) {
   CHECK_ARG(result);
   CHECK_JSRT(JsBoolToBoolean(value, reinterpret_cast<JsValueRef*>(result)));

diff --git a/test/inspector/test-inspector.js b/test/inspector/test-inspector.js
@@ -344,7 +344,10 @@ function testCommandLineAPI(session) {
         checkException(message);
         assert.deepStrictEqual(JSON.parse(message['result']['value']), {
           parentsEqual: true,
-          parentId: '<inspector console>'
+          parentId: common.engineSpecificMessage({
+            v8: '<inspector console>',
+            chakracore: '.'
+          })
         });
       }
     ],