[Merge chakra-core/ChakraCore@d4c8561029] [MERGE #3541 @obastemur] Be…

…tter Debug coverage, smaller binary size Merge pull request #3541 from obastemur:dbg_symx0 - add debug symbols to test builds - keep libwabt debug symbols are being included on release builds.
nodejs · Sep 25, 2017 · b0afaed · b0afaed
1 parent 1685cf3
commit b0afaed
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/deps/chakrashim/core/CMakeLists.txt b/deps/chakrashim/core/CMakeLists.txt
@@ -370,6 +370,7 @@ elseif(CMAKE_BUILD_TYPE STREQUAL Test)
     add_definitions(
         -DENABLE_DEBUG_CONFIG_OPTIONS=1
     )
+    add_compile_options(-g)
 endif(CMAKE_BUILD_TYPE STREQUAL Debug)
 
 if(NOT CMAKE_BUILD_TYPE STREQUAL Debug)

diff --git a/deps/chakrashim/core/lib/wabt/CMakeLists.txt b/deps/chakrashim/core/lib/wabt/CMakeLists.txt
@@ -51,9 +51,6 @@ include_directories(chakra src ${CMAKE_CURRENT_SOURCE_DIR}/built)
 # disable -Wunused-parameter: this is really common when implementing
 #   interfaces, etc.
 # disable -Wpointer-arith: this is a GCC extension, and doesn't work in MSVC.
-add_definitions(
-  -g -std=c++11
-)
 
 if (MINGW)
   # Mingw won't define format (e.g. PRIu64) or limit (e.g. UINT32_MAX) macros