doc,deps,test: fixed deps\test after upgrade to 1.2

**deps** chakrashim simulates StackTrace APIs to align with v8. For `Error.captureStackTrace()` API, it relies on function.name passed to it to filter out stack frames in callstack. However there are 2 problems with this. 1. If user passed `o.p` as function name, chakrashim doesn't filter out as it will try to filter out function name `p` instead (thats what function.name for `o.p` woudl return). I have opened #75 to track this. 2. Currently depending on function passed as an argument is deferred parse `function.name` would return a valid name, else it will return empty. This is bug in chakracore and I am following up with language team. We seems to rely on this bug while patching Error StackTrace APIs. However now, `utils.getStackTrace` function is getting deferred parse and it breaks a unit test. Fixed it by detecting if it is libraryCodecaller or not. Once we have fix from chakracore, we can re-evaluate this fix. **test** Fixed unit test after upgrade. ** doc** There was some information in README.md left over from last merge. Fixed it. PR-URL: #76 Reviewed-By: Jianchun Xu <[email protected]>
nodejs · Jun 14, 2016 · 8641dc0 · 8641dc0
1 parent 4dd7c22
commit 8641dc0
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 16 deletions.
diff --git a/README.md b/README.md
@@ -1,13 +1,6 @@
 Node.js on ChakraCore
 ===
 This project enables Node.js to optionally use the ChakraCore JavaScript engine. This project is still **work in progress** and not an officially supported Node.js branch. Please refer to the original [PR](https://github.com/nodejs/node/pull/4765).
-## Resources for Newcomers
-
-* [Website](https://nodejs.org/en/)
-* [Contributing to the project](./CONTRIBUTING.md)
-* IRC (general questions): [#node.js on chat.freenode.net](https://webchat.freenode.net?channels=node.js&uio=d4)
-* IRC (node core development): [#node-dev on chat.reenode.net](https://webchat.freenode.net?channels=node-dev&uio=d4)
-
 
 ### How it works
 
@@ -41,14 +34,9 @@ vcbuild chakracore nosign [x86|x64|arm]
 ```batch
 vcbuild chakracore nobuild test [x86|x64|arm]
 ```
-* [bengl](https://github.com/bengl) - **Bryan English** &lt;[email protected]&gt;
-* [bmeck](https://github.com/bmeck) - **Bradley Farias** &lt;[email protected]&gt;
-* [firedfox](https://github.com/firedfox) - **Daniel Wang** &lt;[email protected]&gt;
-* [jhamhader](https://github.com/jhamhader) - **Yuval Brik** &lt;[email protected]&gt;
-* [othiym23](https://github.com/othiym23) - **Forrest L Norvell** &lt;[email protected]&gt;
-* [yorkie](https://github.com/yorkie) - **Yorkie Liu** &lt;[email protected]&gt;
 
 To test if Node.js was built correctly with ChakraCore:
+
 ```batch
 C:\>node -e "console.log('Hello from Node.js ' + process.jsEngine)"
 Hello from Node.js chakracore

diff --git a/deps/chakrashim/lib/chakra_shim.js b/deps/chakrashim/lib/chakra_shim.js
@@ -462,7 +462,7 @@
       return props;
     };
     utils.getStackTrace = function() {
-      return captureStackTrace({}, utils.getStackTrace)();
+      return captureStackTrace({}, undefined)();
     };
     utils.isMapIterator = function(value) {
       return value[mapIteratorProperty] == true;

diff --git a/test/parallel/test-process-versions.js b/test/parallel/test-process-versions.js
@@ -10,7 +10,7 @@ if (common.hasCrypto) {
   expected_keys.push('openssl');
 }
 
-if (typeof Intl !== 'undefined') {
+if (!common.isChakraEngine && typeof Intl !== 'undefined') {
   expected_keys.push('icu');
 }
 

diff --git a/test/parallel/test-repl-harmony.js b/test/parallel/test-repl-harmony.js
@@ -9,7 +9,7 @@ var child = spawn(process.execPath, args);
 var input = '(function(){"use strict"; const y=1;y=2})()\n';
 var expectedOutput = common.engineSpecificMessage({
   v8: /^> TypeError: Assignment to constant variable.\n/,
-  chakracore: /^> SyntaxError: Assignment to const\n/
+  chakracore: /^> TypeError: Assignment to const\n/
 });
 
 child.stderr.setEncoding('utf8');