Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim: remove constexpr usage
Browse files Browse the repository at this point in the history
Node v8.x still supports VS2013 for building extensions. Because of this
`constexpr` is not supported. This field isn't required by any code in
v8.x anyway, so just remove it.

PR-URL: #513
Reviewed-By: Seth Brenith <[email protected]>
Reviewed-By: Hitesh Kanwathirtha <[email protected]>
  • Loading branch information
kfarnung committed Apr 10, 2018
1 parent ea8e749 commit 725fc80
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions deps/chakrashim/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -2073,8 +2073,6 @@ class V8_EXPORT ArrayBufferView : public Object {

class V8_EXPORT TypedArray : public ArrayBufferView {
public:
static constexpr size_t kMaxLength =
sizeof(void*) == 4 ? (1u << 30) - 1 : (1u << 31) - 1;
size_t Length();
static TypedArray* Cast(Value* obj);
private:
Expand Down

0 comments on commit 725fc80

Please sign in to comment.