Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
chakrashim: fix lint errors
Browse files Browse the repository at this point in the history
  • Loading branch information
kfarnung committed Jul 9, 2018
1 parent 10dfbbe commit 596e857
Showing 1 changed file with 11 additions and 9 deletions.
20 changes: 11 additions & 9 deletions deps/chakrashim/include/v8.h
Original file line number Diff line number Diff line change
Expand Up @@ -1002,7 +1002,8 @@ class V8_EXPORT ScriptCompiler {
Isolate* isolate, Source* source);

static CachedData* CreateCodeCache(Local<UnboundScript> unbound_script) {
// BUGBUG: https://github.com/nodejs/node-chakracore/issues/560 - need to implement this
// BUGBUG: https://github.com/nodejs/node-chakracore/issues/560 - need to
// implement this
return nullptr;
}

Expand Down Expand Up @@ -1512,14 +1513,15 @@ class V8_EXPORT Object : public Value {
AccessControl settings = DEFAULT,
PropertyAttribute attribute = None));
V8_WARN_UNUSED_RESULT
Maybe<bool> SetAccessor(Local<Context> context,
Local<Name> name,
AccessorNameGetterCallback getter,
AccessorNameSetterCallback setter = 0,
MaybeLocal<Value> data = MaybeLocal<Value>(),
AccessControl settings = DEFAULT,
PropertyAttribute attribute = None,
SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect);
Maybe<bool> SetAccessor(
Local<Context> context,
Local<Name> name,
AccessorNameGetterCallback getter,
AccessorNameSetterCallback setter = 0,
MaybeLocal<Value> data = MaybeLocal<Value>(),
AccessControl settings = DEFAULT,
PropertyAttribute attribute = None,
SideEffectType getter_side_effect_type = SideEffectType::kHasSideEffect);

V8_DEPRECATE_SOON("Use maybe version", Local<Array> GetPropertyNames());
V8_WARN_UNUSED_RESULT MaybeLocal<Array> GetPropertyNames(
Expand Down

0 comments on commit 596e857

Please sign in to comment.