Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fatal error: core.h: No such file or directory breaks build against node 10.2.0 #776

Closed
mkrufky opened this issue May 24, 2018 · 1 comment

Comments

@mkrufky
Copy link
Collaborator

mkrufky commented May 24, 2018

node 10.1.0 was fine, but 10.2.0 introduced this new fatal error:

mk@vujade:~/git/nan$ npm run rebuild-tests 

> [email protected] rebuild-tests /home/mk/git/nan
> node-gyp rebuild --msvs_version=2015 --directory test

make: Entering directory '/home/mk/git/nan/test/build'
  CXX(target) Release/obj.target/accessors/cpp/accessors.o
In file included from ../../nan.h:51:0,
                 from ../cpp/accessors.cpp:9:
/home/mk/.node-gyp/10.2.0/include/node/node.h:53:10: fatal error: core.h: No such file or directory
 #include "core.h"  // NOLINT(build/include_order)
          ^~~~~~~~
compilation terminated.

I first noticed this in CI:
https://travis-ci.org/mkrufky/node-dvbtee/jobs/382993499

...and then I was able to easily reproduce it locally after upgrading node from v10.1.0 to v10.2.0

Oops, this is a node bug, and not NAN's issue: nodejs/node#20921

Will likely end up closing this soon.

@mkrufky mkrufky changed the title built breakage with node 10.2.x fatal error: core.h: No such file or directory breaks build against node 10.2.x May 24, 2018
@mkrufky mkrufky changed the title fatal error: core.h: No such file or directory breaks build against node 10.2.x fatal error: core.h: No such file or directory breaks build against node 10.2.0 May 24, 2018
@mkrufky
Copy link
Collaborator Author

mkrufky commented May 24, 2018

Closing this now -- a fix for it landed upstream in nodejs/node@3f4caec. A 10.2.1 release with that fix should follow shortly. No changes to NAN or any native modules are necessary.

@mkrufky mkrufky closed this as completed May 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant