Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node::MakeCallback() API change for v6 #548

Open
trevnorris opened this issue Mar 23, 2016 · 1 comment
Open

node::MakeCallback() API change for v6 #548

trevnorris opened this issue Mar 23, 2016 · 1 comment
Milestone

Comments

@trevnorris
Copy link
Collaborator

Currently node::MakeCallback() returns Local<Value>. This is problematic for two reasons:

  1. node::AsyncWrap::MakeCallback() returns a Local<Value>() if there's an exception. While the PR hasn't been done, before v6 it will return a MaybeLocal<Value>.
  2. Recursive MakeCallback() calls depends on knowing if an exception was thrown. This is impossible to do since Undefined() is a valid return value.

It should be easy to get around this for backwards compatibility, but would like to make sure nan is ready for the change.

/cc @nodejs/addon-api

@kkoopa
Copy link
Collaborator

kkoopa commented Mar 23, 2016

Good to know. I presume there will be a couple other breaking changes as well, but nothing as major as last year. That ought to mean we can do the right thing and add this change to the breakage list.

However, nothing is final yet regarding what to break. I'll have a look at the state of breakage once release candidates start appearing and I manage to find time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants