Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-gyp: CI job broken? #1294

Closed
bnoordhuis opened this issue May 30, 2018 · 4 comments
Closed

node-gyp: CI job broken? #1294

bnoordhuis opened this issue May 30, 2018 · 4 comments

Comments

@bnoordhuis
Copy link
Member

Not sure what's going on but https://ci.nodejs.org/job/nodegyp-test-pull-request/46/ (first job in quite some time) shows nothing, just that it failed.

@richardlau
Copy link
Member

https://ci.nodejs.org/job/nodegyp-test-pull-request/47/ seems to succeed with the default TARGET_GITHUB_ORG parameter and numeric PR_ID.

On the otherhand, we might need to review the subjobs that are run as it looks like we're still testing on Node.js 7.10.0 (https://ci.nodejs.org/job/nodegyp-test-commit/252/) and Node.js 4.8.3 (https://ci.nodejs.org/job/nodegyp-test-commit/254/) (!) and not currently testing on Node.js 10.

@richardlau
Copy link
Member

And the job only tests on Ubuntu and Windows, which is probably good enough for the common use cases, but nodejs/node-gyp#1451 touches code that was only previously exercised on AIX.

@refack
Copy link
Contributor

refack commented May 30, 2018

I'll give it a scrub-down.

@refack
Copy link
Contributor

refack commented May 30, 2018

Switched platforms to: ubuntu1604-64 & win2016-vs2017
and added node 10 to matrix

image

also added a test that PR_ID is numeric, and unified the build script to use bash on both platforms


As for AIX, I'd say it could stay out of the CI, and the devs involved in patches will need to be manually test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants