Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration cache incompatibility #326

Closed
nbrugger-tgm opened this issue Oct 25, 2024 · 4 comments
Closed

Fix configuration cache incompatibility #326

nbrugger-tgm opened this issue Oct 25, 2024 · 4 comments
Labels
question Further information is requested

Comments

@nbrugger-tgm
Copy link

nbrugger-tgm commented Oct 25, 2024

This plugin is not compatible with gradle configuration cache:

 - Task `:webpage:npmInstall` of type `com.github.gradle.node.npm.task.ConfigurableNpmInstallTask`: invocation of  'Task.project' at execution time is unsupported.
   See https://docs.gradle.org/8.10.2/userguide/configuration_cache.html#config_cache:requirements:use_project_during_execution

Would you accept a contribution (or fix it yourself?)

@nbrugger-tgm
Copy link
Author

nbrugger-tgm commented Oct 25, 2024

I just saw it seems to be present in 3.0.0-rc7 but its broken again

@deepy
Copy link
Member

deepy commented Oct 28, 2024

I don't know where you're getting ConfigurableNpmInstallTask from but I can't find it in the repository's history, and having just tested 7.1.0 I am not getting any configuration-cache errors

Can you create a sample project that reproduces the issue with 7.1.0? I can't accept patches for 3 year old versions

@deepy deepy added the question Further information is requested label Oct 28, 2024
@nbrugger-tgm
Copy link
Author

nbrugger-tgm commented Oct 28, 2024

Oh i see. Good catch. Someone checked in a cloned & modified version of NpmInstallTask that fixed a bug or something long ago (ConfigurableNpmInstallTask) hence it wasn't up-to-date and still containing the project access.

I am sorry for the inconvenience and the misinformation. (I got a bit too used to plugins not being compatible)

I deleted the wrong report in the gradle thread.

@deepy
Copy link
Member

deepy commented Oct 28, 2024

Awesome, thanks :-)

And while I might be slower at responding than usual, we're always open for PRs and feature requests (feature requests moving very slowly at the moment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants