Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NpmTask is abstract #175

Closed
Mazorius opened this issue Jun 7, 2021 · 4 comments
Closed

NpmTask is abstract #175

Mazorius opened this issue Jun 7, 2021 · 4 comments

Comments

@Mazorius
Copy link

Mazorius commented Jun 7, 2021

Why do you need to define the NpmTask as abstract?

The ObjectFactory and ProviderFactory are provided by the project during the apply prozess.

project.objects && project.providers

@deepy
Copy link
Member

deepy commented Jun 7, 2021

The reason it was changed to be abstract was to support the configuration-cache (see #111 for full history) and still be compatible with Gradle 5.

Out of curiosity, why do you need it to be concrete?

@Mazorius
Copy link
Author

Mazorius commented Jun 7, 2021

I tried to create an open class task which breaks with null-pointer exceptions.
I thought it is the case due to the abstract task.

But if this is due to compatibility this is fine for me.

Maybe my skills are not good enough :-)

Thanks

@deepy
Copy link
Member

deepy commented Jun 7, 2021

It's been a while so I can't comment much on the implementation, but in your case, does your class need to be a concrete class?

Even if your task is abstract you should still be able to register/create it as before in the build

@Mazorius
Copy link
Author

Mazorius commented Jun 7, 2021

I will try this :-) Thanks a lot.

Due to the fact that is not a issue more a miss-understanding from my side I will close this issue.

@Mazorius Mazorius closed this as completed Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants