Skip to content
This repository has been archived by the owner on Nov 4, 2022. It is now read-only.

Support pagination with Github API for the Repo command #539

Closed
m-roberts opened this issue Jun 12, 2018 · 0 comments · Fixed by #542
Closed

Support pagination with Github API for the Repo command #539

m-roberts opened this issue Jun 12, 2018 · 0 comments · Fixed by #542

Comments

@m-roberts
Copy link
Contributor

m-roberts commented Jun 12, 2018 •
edited by protoEvangelion
Loading

This is a more generic issue relating to #438.

Currently, gh uses per_page: 1000 in a few places, but the API only supports 100 responses per page.

GitHub expects you to use the metadata supplied by the API to get all the pages using consecutive calls.

gh should handle multiple API requests, as needed, so that the --all flag actually makes sense.
@m-roberts m-roberts mentioned this issue Jun 27, 2018
Merged
@protoEvangelion protoEvangelion changed the title Support pagination with Github API Support pagination with Github API for the Repo command Jun 28, 2018
@protoEvangelion protoEvangelion mentioned this issue Aug 3, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add pagination
1 participant
@m-roberts