fix(pull-request.js): remove throw from pull request submission error…

… handling #567
node-gh · Sep 15, 2018 · cc9eab8 · cc9eab8
1 parent a310da9
commit cc9eab8
Showing 1 changed file with 9 additions and 16 deletions.
diff --git a/lib/cmds/pull-request.js b/lib/cmds/pull-request.js
@@ -1050,25 +1050,18 @@ PullRequest.prototype._submitHandler = function() {
 
         instance.submit(options.submit, function(err, pull) {
             if (err) {
-                try {
-                    if (JSON.parse(err.message).errors[0].message) {
-                        logger.error(
-                            "Can't submit pull request. " +
-                                JSON.parse(err.message).errors[0].message
-                        )
-                    } else {
-                        throw Error
-                    }
-                } catch (ignore) {
-                    if (err.code === 404) {
-                        logger.error("Can't submit pull request. User Not Found")
+                if (err.code === 404) {
+                    logger.error("Can't submit pull request. User Not Found")
+                } else {
+                    err = JSON.parse(err.message).errors[0]
+
+                    if (err.message) {
+                        logger.error("Can't submit pull request. " + err.message)
                     } else {
-                        logger.error(
-                            "Can't submit pull request. " +
-                                JSON.stringify(JSON.parse(err.message).errors[0])
-                        )
+                        logger.error("Can't submit pull request. " + JSON.stringify(err))
                     }
                 }
+
                 return
             }