fix(pull-request): show PR table formatting by default

node-gh · Sep 15, 2019 · 4326fe4 · 4326fe4
1 parent e166317
commit 4326fe4
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/README.md b/README.md
@@ -137,7 +137,7 @@ gh pull-request
 #### Examples
 
 -   **Shortcut** for listing open pull requests for the current repository.
--   To pretty print output in a table add `"pretty_print": true` to your `~/.gh-json` config or to cli like `--prettyPrint`
+-   To turn off pretty printing of output in a table add `"pretty_print": false` to your `~/.gh-json` config
 
 ```
 gh pr

diff --git a/default.gh.json b/default.gh.json
@@ -103,7 +103,7 @@
 
     "plugins": {},
 
-    "pretty_print": false,
+    "pretty_print": true,
 
     "replace": {},
 

diff --git a/package-lock.json b/package-lock.json
diff --git a/src/cmds/pull-request.ts b/src/cmds/pull-request.ts
@@ -748,7 +748,9 @@ PullRequest.prototype.list = async function(user, repo) {
         json.branches.forEach((branch, index, arr) => {
             logger.log(`${logger.colors.blue('Branch:')} ${branch.name} (${branch.total})`)
 
-            if (config.pretty_print || options.prettyPrint) {
+            const printTableView = config.pretty_print === undefined || Boolean(config.pretty_print)
+
+            if (printTableView) {
                 instance.printPullsInfoTable_(branch.pulls)
             } else {
                 branch.pulls.forEach(instance.printPullInfo_, instance)