Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for request timeouts #69

Open
countrodrigo opened this issue Jun 14, 2014 · 5 comments
Open

Add support for request timeouts #69

countrodrigo opened this issue Jun 14, 2014 · 5 comments
Assignees

Comments

@countrodrigo
Copy link
Contributor

There doesn't seem to be to set timeouts on a per request basis. Did I read the code wrong?

@nlf
Copy link
Owner

nlf commented Jun 20, 2014

You're absolutely correct, there isn't currently a per-request timeout.. I'll see what I can come up with.

@countrodrigo
Copy link
Contributor Author

Oh hey, so we actually implemented this in another library, but I think your library already supports it natively. Since you are using the 1.4 protobuf spec, you can already pass in a timeout variable in the request and Riak will implement the timeout itself.

@countrodrigo
Copy link
Contributor Author

That said, it would still be nice to be able to timeout requests that are getting hung up along the way for whatever reason, client side.

@nlf
Copy link
Owner

nlf commented Jun 20, 2014

Yup, you can certainly pass timeout values to the commands that support them. But I agree, a client side timeout like we have for connecting would be nice.

@nlf nlf added this to the 2.0.0 milestone Sep 17, 2014
@nlf nlf self-assigned this Sep 17, 2014
@nlf
Copy link
Owner

nlf commented Sep 17, 2014

I think I'm going to postpone this.. I want to get the 2.0 release out, and this will require more changes than I can manage in a short timeframe.

@nlf nlf removed this from the 2.0.0 milestone Sep 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants