-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for request timeouts #69
Comments
You're absolutely correct, there isn't currently a per-request timeout.. I'll see what I can come up with. |
Oh hey, so we actually implemented this in another library, but I think your library already supports it natively. Since you are using the 1.4 protobuf spec, you can already pass in a timeout variable in the request and Riak will implement the timeout itself. |
That said, it would still be nice to be able to timeout requests that are getting hung up along the way for whatever reason, client side. |
Yup, you can certainly pass timeout values to the commands that support them. But I agree, a client side timeout like we have for connecting would be nice. |
I think I'm going to postpone this.. I want to get the 2.0 release out, and this will require more changes than I can manage in a short timeframe. |
There doesn't seem to be to set timeouts on a per request basis. Did I read the code wrong?
The text was updated successfully, but these errors were encountered: