Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flurry holds memory over benchmark iters #3

Open
nkconnor opened this issue Aug 20, 2020 · 0 comments
Open

Flurry holds memory over benchmark iters #3

nkconnor opened this issue Aug 20, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@nkconnor
Copy link
Owner

https://github.com/jonhoo/flurry/blob/f623ac994f20d35861799d7f106178a875f6e661/src/map_ref.rs#L13

In benchmarks/ we are running Flurry for a number of iterations and garbage never gets cleared. Investigate whether the ^Ref type is needed or another solution to drop garbage after each run.
@nkconnor nkconnor added the good first issue Good for newcomers label Aug 20, 2020
@nkconnor nkconnor changed the title Flurry gets dirty during benchmarking Flurry holds memory over benchmark iters Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nkconnor