Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribute to nix-community? #2

Closed
JamieMagee opened this issue Sep 15, 2020 · 18 comments
Closed

Contribute to nix-community? #2

JamieMagee opened this issue Sep 15, 2020 · 18 comments

Comments

@JamieMagee
Copy link
Member

I started working on a similar project over the weekend (JamieMagee/vscode-nix), and I just discovered your project as well! I don't really want to duplicate any effort, so I think I should contribute to your extension instead.

I was wondering if you would consider re-homing your extension to nix-community and maintaining it there? There was an ask to do this on the existing extension (bbenoist/vscode-nix#6), but the maintainer there appears to be missing. I think that with your extension, the community could more easily contribute (I know I would) and it would be more discoverable for Nix users.

What do you think?

@JamieMagee
Copy link
Member Author

cc: @grahamc as you initially suggested the idea on the other extension

@jnoortheen
Copy link
Collaborator

Sure. How should I start it?

@JamieMagee
Copy link
Member Author

Let's wait and see what Graham's response is.

@JamieMagee
Copy link
Member Author

@jnoortheen
Copy link
Collaborator

I think the core developers mainly use emacs and not concentrating much on other editors. the language server looks great though.

@JamieMagee
Copy link
Member Author

True, but I think there are clearly people who would be interested in this and we should be meeting users where they are, with their own tools, instead of forcing other tools onto them.

@grahamc
Copy link
Member

grahamc commented Sep 23, 2020

Sounds like a good idea :) I'll cc nix-community

@Mic92
Copy link
Member

Mic92 commented Sep 23, 2020

@JamieMagee @jnoortheen I sent you both an invite. One of you can move over the repo. Than I will create a team with both of you in.

@JamieMagee
Copy link
Member Author

@Mic92 Thanks! I've accepted the invite. I would recommend migrating @jnoortheen's repo, as it's further along in development than the one I created.

@jnoortheen
Copy link
Collaborator

I am transfering the repo.

@jnoortheen
Copy link
Collaborator

moved the repo.

Thanks @JamieMagee @Mic92

PR welcome for Language Server feature.

@Mic92
Copy link
Member

Mic92 commented Sep 24, 2020

I moved you both in a team where you can do maintain the repo.

@jnoortheen
Copy link
Collaborator

jnoortheen commented Oct 24, 2020

@Mic92
I need to set some secrets, to publish using GitHub actions. Also need to set main as the default branch and remove master.
Could you enable access for it?

@jnoortheen
Copy link
Collaborator

@jnoortheen
Copy link
Collaborator

Any updates? @Mic92 I am not sure whom I could ping for this.

@Mic92
Copy link
Member

Mic92 commented Oct 27, 2020

@jnoortheen I increased the privileges to include admin rights. You should be now able to add secrets. Otherwise ping @Mic92 on IRC in #nix-community

@Mic92
Copy link
Member

Mic92 commented Oct 27, 2020

I changed the default branch from master to main.

@jnoortheen
Copy link
Collaborator

I changed the default branch from master to main.

Thanks. I will check it this weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants