From 69244a7ee224abf5aad77e28ac7d412a20b40ab8 Mon Sep 17 00:00:00 2001 From: jmgomez Date: Sat, 14 Dec 2024 11:44:30 +0000 Subject: [PATCH 1/2] #Fixes #24536 building nimble 0.16.4 fails when running build_all.sh --- build_all.bat | 2 +- build_all.sh | 2 +- tools/deps.nim | 6 ++++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/build_all.bat b/build_all.bat index bef7956f28401..e4d8ec31e546e 100644 --- a/build_all.bat +++ b/build_all.bat @@ -26,4 +26,4 @@ if not exist %nim_csources% ( ) bin\nim.exe c --noNimblePath --skipUserCfg --skipParentCfg --hints:off koch koch boot -d:release --skipUserCfg --skipParentCfg --hints:off -koch tools --skipUserCfg --skipParentCfg --hints:off +koch tools --skipUserCfg --hints:off diff --git a/build_all.sh b/build_all.sh index 83848f41a1def..ddb8891a1f63c 100755 --- a/build_all.sh +++ b/build_all.sh @@ -13,5 +13,5 @@ nimBuildCsourcesIfNeeded "$@" echo_run bin/nim c --noNimblePath --skipUserCfg --skipParentCfg --hints:off koch echo_run ./koch boot -d:release --skipUserCfg --skipParentCfg --hints:off -echo_run ./koch tools --skipUserCfg --skipParentCfg --hints:off +echo_run ./koch tools --skipUserCfg --hints:off diff --git a/tools/deps.nim b/tools/deps.nim index 6568de7ff2033..cc50cedb53a79 100644 --- a/tools/deps.nim +++ b/tools/deps.nim @@ -46,5 +46,7 @@ proc cloneDependency*(destDirBase: string, url: string, commit = commitHead, proc updateSubmodules*(dir: string) = let oldDir = getCurrentDir() setCurrentDir(dir) - exec "git submodule update --init" - setCurrentDir(oldDir) + try: + exec "git submodule update --init" + finally: + setCurrentDir(oldDir) \ No newline at end of file From 0dc6837d3b435a3e4b9f3aac17c455925300bbf3 Mon Sep 17 00:00:00 2001 From: jmgomez Date: Sat, 14 Dec 2024 15:09:10 +0000 Subject: [PATCH 2/2] updates genBuildExtras --- tools/ci_generate.nim | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/ci_generate.nim b/tools/ci_generate.nim index a461be5915b94..a9635d02dbc92 100644 --- a/tools/ci_generate.nim +++ b/tools/ci_generate.nim @@ -44,7 +44,7 @@ proc genBuildExtras(echoRun, koch, nim: string): string = result = fmt""" {echoRun}{nim} c --noNimblePath --skipUserCfg --skipParentCfg --hints:off koch {echoRun}{koch} boot -d:release --skipUserCfg --skipParentCfg --hints:off -{echoRun}{koch} tools --skipUserCfg --skipParentCfg --hints:off +{echoRun}{koch} tools --skipUserCfg --hints:off """ proc genWindowsScript(buildAll: bool): string =