Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to exportc params. #23396

Merged
merged 1 commit into from
May 10, 2024
Merged

Allow to exportc params. #23396

merged 1 commit into from
May 10, 2024

Conversation

jmgomez
Copy link
Collaborator

@jmgomez jmgomez commented Mar 12, 2024

By allowing exportc in params one can decide the name of a param or to dont mangle them.

By allowing exportc in pragmas one can decide the name of a param or to dont unmangle them.
@@ -88,7 +88,7 @@ const
wGensym, wInject,
wIntDefine, wStrDefine, wBoolDefine, wDefine,
wCompilerProc, wCore}
paramPragmas* = {wNoalias, wInject, wGensym, wByRef, wByCopy, wCodegenDecl}
paramPragmas* = {wNoalias, wInject, wGensym, wByRef, wByCopy, wCodegenDecl, wExportc, wExportCpp}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
paramPragmas* = {wNoalias, wInject, wGensym, wByRef, wByCopy, wCodegenDecl, wExportc, wExportCpp}
paramPragmas* = {wNoalias, wInject, wGensym, wByRef, wByCopy, wCodegenDecl, wExportC, wExportCpp}

🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmgomez jmgomez closed this Mar 12, 2024
@jmgomez jmgomez reopened this Mar 12, 2024
@jmgomez jmgomez closed this Mar 12, 2024
@jmgomez jmgomez reopened this Mar 12, 2024
@jmgomez jmgomez closed this Mar 14, 2024
@jmgomez jmgomez reopened this Mar 14, 2024
@Araq Araq merged commit fcc43fa into nim-lang:devel May 10, 2024
56 of 58 checks passed
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from fcc43fa

Hint: mm: orc; opt: speed; options: -d:release
178560 lines; 8.245s; 753.055MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants