Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix isAbsolute broken when nodejs on Windows #23365

Merged
merged 1 commit into from
Mar 4, 2024
Merged

fix isAbsolute broken when nodejs on Windows #23365

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/std/private/ospaths2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,10 +254,10 @@ proc isAbsolute*(path: string): bool {.rtl, noSideEffect, extern: "nos$1", raise
result = path[0] != ':'
elif defined(RISCOS):
result = path[0] == '$'
elif defined(posix) or defined(js):
# `or defined(js)` wouldn't be needed pending https://github.com/nim-lang/Nim/issues/13469
# This works around the problem for posix, but Windows is still broken with nim js -d:nodejs
elif defined(posix):
result = path[0] == '/'
elif defined(nodejs):
{.emit: [result," = require(\"path\").isAbsolute(",path.cstring,");"].}
else:
raiseAssert "unreachable" # if ever hits here, adapt as needed

Expand Down
Loading