fix isAbsolute broken when nodejs on Windows
#23365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When target is nodejs, `isAbsolute` used to only check in the POSIX flavor, i.e. broken on Windows. This fixes it.
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
litlighilit
added a commit
to litlighilit/Nim
that referenced
this pull request
Mar 8, 2024
Windows `isAbsolute` issue has been resolved by [this PR](nim-lang#23365). So we can improve the coverage for Windows
heterodoxic
pushed a commit
to heterodoxic/Nim
that referenced
this pull request
Mar 11, 2024
…ws. (nim-lang#23377) Windows's nodejs `isAbsolute` issue has been resolved by [this PR](nim-lang#23365). So we can improve the coverage for Windows.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When target is nodejs,
isAbsoluteused to only check in the POSIX flavor,i.e. for js backend on Windows,
This fixes it.