Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #20945; fixes #18262; provides C API NimDestroyGlobals for static/dynlib libraries #23357

Merged
merged 3 commits into from
Mar 4, 2024

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Feb 27, 2024

fixes #20945
fixes #18262

todo

  • perhaps export with lib prefix when the option is enabled

@ringabout ringabout changed the title fixes #20945; fixes #18262; provides C API nimDestroyGlobals for static/dynlib libraries fixes #20945; fixes #18262; provides C API NimDestroyGlobals for static/dynlib libraries Feb 27, 2024
@ringabout ringabout marked this pull request as ready for review February 27, 2024 14:23
@Araq Araq merged commit e217bb2 into devel Mar 4, 2024
22 checks passed
@Araq Araq deleted the pr_destroy_globals branch March 4, 2024 09:14
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from e217bb2

Hint: mm: orc; opt: speed; options: -d:release
178231 lines; 7.550s; 768.312MiB peakmem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler doesn't insert call to =destroy when compiled to staticLib Global objects are not freed with noMain
2 participants