-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[superseded] fix #14142: no more clash with: import os + use of existsDir/dirExists/existsFile/fileExists/findExe in config.nims #14143
Conversation
I spend effort on this error message, why remove it? |
because the problems in #14142 are real and outweigh the benefits of having a nicer error message. In following example, example
# in main.nims (eg user config.nims or any other nims file)
import pkg/foo
# in pkg/foo.nim
import os
echo existsFile("/tmp/z01.txt") # Error: redefinition
|
…dirExists/existsFile/fileExists/findExe in config.nims
9db29cb
to
75ac5f8
Compare
The error message must stay. |
I don't understand why producing an error here is so important; what is your alternative proposal to #14658 to fix #14179, #14142 and the regression introduced in 3d2459b that makes CI 1.4X times slower (or more generally makes nim slower for any command, which especially matters for short lived commands like |
superseded by #14658 |
/cc @Araq
future work
nim c
behaviorimport os
for these and it'd work via vmops--nimsimports:off
with semantics:--nimsimports:off
# doesn't import anything, user has to import relevant module (eg os); will be default in some future tag 1.3.X--nimsimports:on
# default until 1.3.x, gives a new warning while it's on