Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous integration to build binaries #9

Open
michaelsanford opened this issue Dec 6, 2021 · 5 comments
Open

Continuous integration to build binaries #9

michaelsanford opened this issue Dec 6, 2021 · 5 comments
Labels
enhancement New feature or request

Comments

@michaelsanford
Copy link

michaelsanford commented Dec 6, 2021

Would you accept a PR to do a CI build of native binaries in order to distribute it to those who don't have or want the go toolchain?

( Super cool tool ! )

@nikolaydubina
Copy link
Owner

Hey, Sure! GitHub Actions and storing them in GitHub would be great!

image

tbh, I always getting tools written in Go with go install, not sure how many users getting tools by binaries! (homebrew is good, but too much hustle to add it seems!)

@nikolaydubina nikolaydubina added the enhancement New feature or request label Dec 7, 2021
@michaelsanford
Copy link
Author

Cool, I'll take a stab at it! I've done this before with Appveyor, but I prefer to try with Github Actions since it's now available; you seem ok with this plan.

No ETA right now, but I'll have more time over the holiday break.

I agree that go install is perfectly idiomatic. My suggestion came up because I suggested this tool to some people in my Operations team, and they don't have any go dev environment and don't want to manage one.

@mlange-42
Copy link
Contributor

For reference, here is a GitHub Actions script that builds binaries for win, linux and macos and uploads them as release assets: https://github.com/mlange-42/dirstat/blob/main/.github/workflows/release.yml

Could also use a build matrix to reduce code repetitions.

@nikolaydubina
Copy link
Owner

these days I am inclined not distribute binaries for Go projects.

I would rather keep go install version.

Let's see if there is enough traction for non Go community, then let's def add binaries!

@nikolaydubina
Copy link
Owner

keeping issue open. will collect requests here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants